Skip to content

in_prometheus_remote_write: add missing config param descriptions #11378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eschabell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

in_prometheus_remote_write: add missing config param descriptions #11378

eschabell wants to merge 1 commit into from
+3 −3

Conversation

@eschabell
Copy link
Contributor

@eschabell eschabell commented Jan 20, 2026 •
edited by coderabbitai bot
Loading

  • add missing http2 description
  • add missing buffer_max_size description
  • add buffer_chunk_size missing description

Fixes #11377

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [ N/A ] Example configuration file for the change
  • [ N/A ] Debug log output from testing the change
  • [ N/A ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ N/A ] Run local packaging test showing all targets (including any new ones) build.
  • [ N/A ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ Yes ] Documentation required for this feature

Issue: fluent/fluent-bit-docs#2333
PR: fluent/fluent-bit-docs#2334

Backporting

  • [ N/A ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Documentation
    • Updated configuration option descriptions to include helpful text for HTTP/2 support, maximum HTTP request buffer size, and buffer chunk allocation settings.

✏️ Tip: You can customize this high-level summary in your review settings.

@eschabell
in_prometheus_remote_write: add missing config param descriptions
37c4dc7 
 - add missing http2 description
 - add missing buffer_max_size description
 - add buffer_chunk_size missing description

Fixes fluent#11377

Signed-off-by: Eric D. Schabell <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request adds missing descriptive help text for three configuration parameters in the prometheus_remote_write plugin: http2, buffer_max_size, and buffer_chunk_size. The changes replace null or empty string values with user-facing descriptions in the configuration map.

Changes

Cohort / File(s) Summary
Configuration Parameter Documentation
plugins/in_prometheus_remote_write/prom_rw.c		 Added help descriptions for three config parameters: http2 ("Enable HTTP/2 support"), buffer_max_size ("Maximum size of the HTTP request buffer"), and buffer_chunk_size ("Size of each buffer chunk allocated for HTTP requests").

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Suggested labels

docs-required

Suggested reviewers

  • edsiper
  • cosmo0920

Poem

🐰 With whiskers twitching, I hop with glee,
Three helpers now described so clear to see!
HTTP2, buffers—no mystery remains,
Configuration blooms through these helpful refrains! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: adding missing configuration parameter descriptions to the in_prometheus_remote_write plugin.
Linked Issues check ✅ Passed The pull request directly addresses issue #11377 by adding help descriptions for the three missing parameters (http2, buffer_max_size, buffer_chunk_size) as required.
Out of Scope Changes check ✅ Passed All changes are scoped to adding missing config parameter descriptions for the in_prometheus_remote_write plugin; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Jan 20, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edsiper edsiper Awaiting requested review from edsiper edsiper is a code owner

@cosmo0920 cosmo0920 Awaiting requested review from cosmo0920 cosmo0920 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

docs-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

in_prometheus_remote_write: missing descriptions for configuration parameters

1 participant

@eschabell